fix(ui): Consolidate GitHub settings into General + add gh CLI tool section#326
Merged
Conversation
…ection The GitHub settings tab held a single setting (Remote PR feed cap), so move it under General → Git, directly below Protected Branches, and drop the dedicated tab to reduce visual clutter. Add a `gh` entry to the Tools tab — both a Status row and a full tool section mirroring tmux — so users can see at a glance whether the GitHub CLI is installed and authenticated. Remote PR features depend on it, so it belongs alongside the other first-class tool integrations. - GhCliProbe gains a `version` property parsed from `gh --version` - Settings.gh.* strings extracted into Strings+Gh.swift to keep the outer enum under SwiftLint's type-body-length limit Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub settings tab held a single setting (Remote PR feed cap), so this consolidates it into the General → Git section directly under Protected Branches and removes the dedicated tab. Reduces visual clutter in Settings.
Also adds a
ghentry to the Tools tab — both a Status row and a full tool section mirroring tmux — so users can see at a glance whether the GitHub CLI is installed and authenticated. Remote PR features depend on it, so it belongs alongside the other first-class tool integrations.Changes
gitHubSettingsTab case and deleteSettingsGitHubView.swiftSettingsGeneralViewGit sectionGhCliProbegains aversionproperty parsed fromgh --versionSettings.gh.*intoStrings+Gh.swiftto keep the outer enum under SwiftLint's type-body-length limitsettings.tab.github/settings.github.section.feedkeys from all 40 locales; add 13 newsettings.gh.*keys (kept verbatim in English per the existing tool-settings convention)Testing
🤖 Generated with Claude Code