fix(sparkle): Fix Settings update button and improve release notes formatting#95
Merged
Merged
Conversation
…rmatting This commit completes Phase 7 Sparkle testing fixes: **Settings Button Fix:** - Fixed "Check for Updates" button being disabled in Settings → Updates - Root cause: UpdaterViewModel was created with fallback updater (startingUpdater: false) - Solution: Store UpdaterViewModel in TermQAppDelegate and inject via @EnvironmentObject - Button now uses same SPUStandardUpdaterController as Menu Bar - Removed .disabled() modifier (Menu Bar has no such constraint) **Appcast HTML Formatting:** - Release notes now converted from Markdown to HTML using pandoc - Added markdown_to_html() function to generate-appcast.sh - Sparkle renders proper HTML instead of raw Markdown syntax (##, ***, etc.) - Added pandoc dependency to CI workflows (update-appcast.yml, validate-scripts.yml) **Debug Build Warning:** - Added orange warning in Settings → Updates for Debug builds - Warns that updates will install Production version - Localized strings: settings.debug.update.warning.title/message - Synced to all 40 language files with placeholders **Architecture Changes:** - UpdaterViewModel now stored in TermQAppDelegate.updaterViewModel - Settings receives UpdaterViewModel via @EnvironmentObject from app level - Controller reference stored in UpdaterViewModel for proper update triggering **Files Modified:** - Sources/TermQ/TermQApp.swift (UpdaterViewModel architecture) - Sources/TermQ/Views/SettingsGeneralView.swift (DEBUG warning, button enabled) - Sources/TermQ/Views/SettingsView.swift (@EnvironmentObject injection) - scripts/generate-appcast.sh (Markdown to HTML conversion) - .github/workflows/update-appcast.yml (added pandoc) - .github/workflows/validate-scripts.yml (added pandoc) - Docs/appcast.xml (regenerated with HTML) - Docs/appcast-beta.xml (regenerated with HTML) **Testing Notes:** - Phase 7 testing complete (Tests 7.1-7.3 pass, 7.4 requires production build) - Signature validation working correctly (rejects mismatched updates) - Version comparison works (with SUStandardVersionComparator caveats) Closes Phase 7 Sparkle stabilization testing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes Phase 7 Sparkle testing fixes with three main improvements:
Settings Button Fix ✅
UpdaterViewModelwas created with fallback updater (startingUpdater: false) whenNSApp.delegatewasn't available during@StateObjectinitializationUpdaterViewModelinTermQAppDelegateand inject via@EnvironmentObjectSPUStandardUpdaterControlleras the Menu Bar "Check for Updates"Appcast HTML Formatting 🎨
pandoc##,###,**text**, etc.)markdown_to_html()function toscripts/generate-appcast.shpandocdependency to CI workflowsDebug Build Warning⚠️
Test Plan
make checkpasses)Related
🤖 Generated with Claude Code