(exa PR) 941: Show mounted filesystems and btrfs subvolumes

[cafkafk]

ogham/exa#941

tests

• tests
• optionflag
• documentation
• consider different output format

[cafkafk]

cargo test passes, this seems cool but perhaps it should be hidden behind a option flag?

[sbatial]

I like the idea as well.
I'd have to test it to give a final judgement.

But yes. I feel like this should be behind an option

Also: I don't see any new tests. It might make sense to add some for such a feature

[cafkafk]

Also: I don't see any new tests. It might make sense to add some for such a feature

Agreed, needs tests, option and documentation.

[sbatial]

I have tested it and although I am a bit confused about the chosen rendering (the curly braces) it seems to work.

According to ogham/exa#434 (comment) @ogham found it very useful as well back then so looking good so far

[cafkafk]

although I am a bit confused about the chosen rendering (the curly braces)

Another thing to change before merging perhaps?

[sbatial]

@daviessm seems to be active on github so maybe they have any insight on why they did it that way

[daviessm]

This was the fist bit of Rust code I ever wrote, sorry if it's a bit strange. I'm open to changing any of the symbols used - I was awaiting feedback from the exa people. Particularly the flashing...

Regarding tests - is it possible to do tests without a btrfs filesystem?

I can add all of this in over the next few weeks if you give me some pointers.

[sbatial]

Regarding tests - is it possible to do tests without a btrfs filesystem?

I'm not sure but I would say it could be given that the information would have to be a file or file attribute.
I would need to look deeper into this myself but it looks like the crate used has some tests of their own.

Maybe they help to gain more insight: https://github.com/pop-os/proc-mounts/blob/master/src/mounts/mod.rs

[daviessm]

Ok; should I start a new PR or should I submit a PR to this branch?

[cafkafk]

Ok; should I start a new PR or should I submit a PR to this branch?

I'd actually prefer a new PR (that way I can add myself as a reviewer), bonus points if you follow https://www.conventionalcommits.org/en/v1.0.0/

[sbatial]

Closing in favor of new PR.

[daviessm]

New PR: #167