(exa PR) 908: Don’t show icons when piped (also add --icons={always,auto,never})

[cafkafk]

https:/github.com/ogham/exa/pull/908

[github-actions]

This pull request is stale because it has been open for 30 days with no activity.

[PThorpe92]

hmm. Moving to 1.70 stabilizes is_terminal() correct?

This could use revisiting after the move for sure, but i'm fixing it now to see whats up with it.

[ariasuni]

@PThorpe92 I don’t understand why you removed the always option, it’s useful when you want to show icons when piped, similar to the --colour option.

[PThorpe92]

I'm sorry you are right, it's very possible that I fixed that locally. This just shows the initial fix of the merge conflicts here. I worked on it a bunch locally but couldn't get the dont show in TTY | piped option working in all cases. I really need to look at it again i've just been super busy.

Ok I had just enough time to clean this up and tinker with it a little, but I don't think it's ready yet. I'll have more time this weekend. @ariasuni if you want to review and let me know if anything sticks out to you.

[PThorpe92]

should close #527 and i think at least one more.

I think this should be all set now. The only thing is this will break everyone's alias's because the always, auto, never are traditionally a necessary argument flag.

[cafkafk]

I think this should be all set now. The only thing is this will break everyone's alias's because the always, auto, never are traditionally a necessary argument flag.

Could we have it so --icons by itself implied --icons=auto? That way we're still almost backwards compat, and I think it's probably the most sensible option... What do you think?

[cafkafk]

We probably need to update bash, zsh, fish, and nushell completions, as well as the manual and README.md

[cafkafk]

Could you potentially reopen this as a PR by you instead, I can't make suggestions like normally on my own PR :s

[PThorpe92]

Oh yup. gotta do the docs and completions still. Yeah it was wierd trying to request ur review on ur own PR :P I'll re open one

[PThorpe92]

Closing to open a new one.. I added more functionality