Skip to content

Fix hook type is invalid#3

Open
dracher wants to merge 1 commit intofabiand:masterfrom
dracher:feature/hook-fix
Open

Fix hook type is invalid#3
dracher wants to merge 1 commit intofabiand:masterfrom
dracher:feature/hook-fix

Conversation

@dracher
Copy link
Contributor

@dracher dracher commented Aug 14, 2013

e.g.: 'post-job' should run only one time after each job,
but before fix it will run eveywhere when hook is triggered.

e.g.: 'post-job' should run only one time after each job,
but before fix it will run eveywhere when hook is triggered.
@dracher
Copy link
Contributor Author

dracher commented Aug 15, 2013

Thanks for the explanation, yes crystal clear now.
Except one question.
If i put a hook named check_ssh_connection in hook.d directory. I only wish this hook will be executed in the middle of one test-case. Should i add this in test-case?

r = redis.Redis()
r.publish(common.REDIS_EVENTS_PUBSUB_CHANNEL_NAME,
          "<event type='%s' session='%s' />" % ("check_ssh_connection", cookie))

@dracher dracher closed this Aug 15, 2013
@dracher dracher reopened this Aug 15, 2013
@dracher dracher closed this Aug 15, 2013
@fabiand
Copy link
Owner

fabiand commented Aug 19, 2013

@dracher you can do that. But I'd rather recommend to query the status of the job when the hok is run and check from the status informations at which step the current job is.

I suppose that https://bugzilla.redhat.com/show_bug.cgi?id=980068 is what you try to implement, is that correct?

@fabiand fabiand reopened this Aug 19, 2013
@dracher
Copy link
Contributor Author

dracher commented Aug 20, 2013

@fabiand yes, that's exactly what i expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants