Run CMD on ttyS0 after login and exit the VM after CMD is finished#5
Open
rmohr wants to merge 2 commits intofabiand:masterfrom
Open
Run CMD on ttyS0 after login and exit the VM after CMD is finished#5rmohr wants to merge 2 commits intofabiand:masterfrom
rmohr wants to merge 2 commits intofabiand:masterfrom
Conversation
vocker
Outdated
|
|
||
| with tempfile.NamedTemporaryFile("wb") as spec: | ||
| spec.write(xml) | ||
| spec.write(xml.encode()) |
Owner
There was a problem hiding this comment.
I think we need it earlier:
@@ -305,7 +309,7 @@ if __name__ == "__main__":
"--rng", "/dev/random",
"--noautoconsole",
"--print-xml")
- xml = str(xml)
+ xml = str(xml).encode("UTF-8")
Contributor
Author
There was a problem hiding this comment.
I don't think so.
domroot = ET.fromstring(xml)
at line 322 would not work then
A very simple way to have automatic login with everything set up and making sure that we run CMD only once by checking in .bashrc if tty confirms that we run on ttyS0. After CMD is done, 'shutdown -h now' is invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We somehow have to make sure that SPICE always uses ttyS0