fix(mobile-api): align settings page chrome with standard admin settings#195
fix(mobile-api): align settings page chrome with standard admin settings#195fabiodalez-dev wants to merge 1 commit into
Conversation
…ettings The Mobile API plugin settings page diverged from every other settings page: a sticky header bar with an indigo→purple gradient icon box and indigo/purple accents throughout, instead of the canonical admin chrome (plain text-3xl heading + flat blue icon, blue accents, .btn-primary). Now it matches /admin/settings and the sibling plugin settings pages (api-book-scraper, discogs): - header: drop the sticky bar + gradient icon, use the text-3xl heading with a flat fa-mobile-screen-button text-blue-600 icon and a .btn-secondary "Plugin" back link - recolor every indigo-* accent to blue-* (tabs, toggle, info box, selects, focus rings) - save button → .btn-primary; success/error banners → the canonical px-4 py-3 rounded-lg green/red style
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLa vista delle impostazioni Mobile API aggiorna wrapper, notifiche, tab, checkbox di accesso, callout attiva, controlli push e pulsante di salvataggio, sostituendo varie classi indigo con blue e ChangesRitocco UI delle impostazioni Mobile API
🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Assorbita in #196 (che la include per intero insieme al resto dell'omogeneizzazione UI). Chiudo qui. |
Problema
La pagina impostazioni del plugin Mobile API (
/admin/plugins/{id}/settings) era l'unico settings full-page a divergere dal resto dell'admin: header sticky con icona a gradiente indigo→purple e accenti indigo/purple ovunque, invece del chrome canonico usato da/admin/settingse dagli altri plugin settings (api-book-scraper,discogs).Soluzione
Un solo file —
storage/plugins/mobile-api/views/settings.php— allineato al pattern canonico:<h1 class="text-3xl font-bold text-gray-900">con icona piattafas fa-mobile-screen-button text-blue-600e back link.btn-secondary, dentromax-w-4xl mx-auto.indigo-*→blue-*(tab, toggle, box "API attiva", select, focus ring). Zero gradient/indigo/purple residui..btn-primary(identico al "Salva" del Centro Impostazioni); banner success/error → stile canonicopx-4 py-3 rounded-lg.Verifica
Login reale su Apache
:8081+ screenshot comparativo con/admin/settings: header, card bianche, bottone scuro.btn-primarye accenti blu ora combaciano.php -lok, pre-commit (PHPStan L5 + escaping) verde.Audit di coerenza
Gli altri settings full-page (
api-book-scraper,discogs) erano già canonici.goodlibè renderizzato in un modal (renderSettingsHtml(), nongetSettingsViewPath()) quindi non ha — né deve avere — un header di pagina: non è un outlier.Summary by CodeRabbit