Update _get_failure_rate_exceeded_error to reference Metric Fetching Errors #4780
+35
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bernardbeckerman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90888949. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4780 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 587 587
Lines 61293 61294 +1
=======================================
+ Hits 59274 59275 +1
Misses 2019 2019 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jan 20, 2026
…Errors (facebook#4780) Summary: Updates wording of the FailureRateExceededError, including informing the user when Metric Fetching Errors are to blame for the orchestrator exceeding failure rate. Reviewed By: mpolson64 Differential Revision: D90888949
bernardbeckerman
force-pushed
the
export-D90888949
branch
from
d63f5f8 to
78e944a
Compare
Summary: When a metric used in the OptimizationConfig fails to fetch, mark the trial as ABANDONED rather than FAILED so that it is less likely to be tried again. Reviewed By: mpolson64 Differential Revision: D90884185
…Errors (facebook#4780) Summary: Updates wording of the FailureRateExceededError, including informing the user when Metric Fetching Errors are to blame for the orchestrator exceeding failure rate. Reviewed By: mpolson64 Differential Revision: D90888949
bernardbeckerman
force-pushed
the
export-D90888949
branch
from
78e944a to
8e0e09d
Compare
|
This pull request has been merged in 6045c31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates wording of the FailureRateExceededError, including informing the user when Metric Fetching Errors are to blame for the orchestrator exceeding failure rate.
Differential Revision: D90888949