Remove serializationmixin from transition criterion #4785
+1,257
−977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D80128678
meta-cla
bot
added
the
CLA Signed
Summary: Pull Request resolved: facebook#4785 To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead. Differential Revision: D90802656
mgarrard
force-pushed
the
export-D90802656
branch
from
4372f7b to
7fbfd33
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4785 +/- ##
==========================================
- Coverage 96.71% 96.70% -0.01%
==========================================
Files 587 587
Lines 61311 61264 -47
==========================================
- Hits 59295 59244 -51
- Misses 2016 2020 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead. Reviewed By: saitcakmak Differential Revision: D90802656
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead. Reviewed By: saitcakmak Differential Revision: D90802656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead.
Differential Revision: D90802656