Reap MinimumTrialsInStatus #4786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
force-pushed
the
export-D91011637
branch
from
61cbf7b to
394a1d0
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
force-pushed
the
export-D91011637
branch
from
394a1d0 to
15b0ffa
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4786 +/- ##
==========================================
- Coverage 96.70% 96.70% -0.01%
==========================================
Files 587 587
Lines 61294 61307 +13
==========================================
+ Hits 59273 59284 +11
- Misses 2021 2023 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: To align with our standards of only using serializationmixin inheritance in ax objects that are comprised of basic properties (ie not composed of other ax objects), this diff removes the serialization mixin inheritance from TransitionCriteria and better leverages custom encoders/decoders instead. Reviewed By: saitcakmak Differential Revision: D90802656
…#4507) Summary: This is step 1 to making `transition_to` a required argument on TC. We'll make maxparallelism point to self, since it should stay on it's current node when met or unmet. Reviewed By: saitcakmak Differential Revision: D86066476
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
force-pushed
the
export-D91011637
branch
from
15b0ffa to
05296a9
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 21, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria Reviewed By: saitcakmak Differential Revision: D91011637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was used by AEPsych and is a legacy completion criterion, the functionality can be replaced with MinTrials and brings up one step closer to being able to reap completion criteria
Differential Revision: D91011637