Validated uniqueness of TC repr method #4787
Open
+1,344
−1,028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D80128678
…racked changes) Differential Revision: D90802656
Differential Revision: D86066476
Differential Revision: D91011637
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Differential Revision: D91011862
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state
Differential Revision: D91011862