docs: clarify Node and Corepack setup#3294
Conversation
|
@koriyoshi2041 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @koriyoshi2041! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thanks for tackling this - the troubleshooting section directly addresses the confusion in #3288. One suggestion: I'd keep "Node 22+ (LTS)" rather than hard-pinning to exactly 22. pnpm just needs Node 22+, and a single pinned version ages out - Node 24 is already the current Active LTS, with 26 landing this fall. Recommending "an active LTS line" keeps this durable without bumping the docs each cycle. I'd also frame the Node choice as independent from Corepack. Right now it reads a bit like "use 22 so Corepack works," but we shouldn't pin Node just to keep Corepack around. The TSC voted to stop shipping Corepack with Node 25+ - that's the intended direction, and it's fine. Corepack is a nice convenience (auto-honoring the pinned So I'd suggest: recommend an active LTS (22+), with two equally-valid ways to get pnpm -
npm install -g corepack
corepack enableThat way the Corepack path still works for anyone who wants it, regardless of Node version, and we're not tying our recommended Node version to a tool that's being unbundled. |
|
Updated this to recommend an active LTS line (22+) instead of hard-pinning exactly 22, and split pnpm setup into two paths: direct pnpm install or Corepack for the pinned version. I also added the manual Corepack install path for Node versions that no longer bundle it.
|
Summary
Verification
Fixes #3270
Fixes #3288