fix(datetimeinput): correct time-input label query in invalid-input tests#3445
Merged
Conversation
…ests
The invalid-typed-time tests queried getByLabelText('Time'), but the
time sub-input's accessible name is `${label} time` (e.g. 'Meeting
time'). Align the 3 queries with the actual label so the suite passes.
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
nynexman4464
approved these changes
Jul 2, 2026
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three DateTimeInput tests (added in #3403, forms-8) query the time sub-input via
getByLabelText('Time'), but the time input's accessible name is${label} time(e.g. "Meeting time"). After #3403 merged, these 3 tests fail onmainwith "Unable to find a label with the text of: Time", turning the requiredtestcheck red.Fix
Align the 3 queries with the actual label (
getByLabelText('Meeting time')), matching every other test in the file. Test-only change; no component behavior change.Part of the accessibility & keyboard-management program (#3343).