Skip to content

fix(menu): typeahead in ContextMenu + NavHeadingMenu (re-land #3432)#3446

Closed
cixzhang wants to merge 1 commit into
mainfrom
navi/feat/typeahead-context-menus-v2
Closed

fix(menu): typeahead in ContextMenu + NavHeadingMenu (re-land #3432)#3446
cixzhang wants to merge 1 commit into
mainfrom
navi/feat/typeahead-context-menus-v2

Conversation

@cixzhang

@cixzhang cixzhang commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Re-lands the ContextMenu + NavHeadingMenu typeahead wiring from #3432.

Why this exists

#3432 was merged into its stacked base branch (`navi/feat/use-typeahead`) instead of `main`, so its content never reached `main`. This PR reapplies that same change (commit c7cc818) on top of current `main`, which already includes the merged a11y fixes to these components (e.g. the ContextMenu label rename and `useLongPress` work).

Dependency

This wiring depends on the shared `useTypeahead` hook (`packages/core/src/hooks/useTypeahead.ts`), which is not yet in `main` — it lands separately via #3431 (approved, awaiting merge). This PR must merge after #3431.

Verified locally with the hook present (simulating #3431 landed):

  • `vitest` ContextMenu + NavMenu — 44 passed (incl. new typeahead test)
  • `eslint` changed files — clean
  • `tsc` core project — exit 0
  • `check-sync` — clean

Without the hook in `main`, `tsc` reports `Cannot find module '../hooks/useTypeahead'` — this resolves once #3431 merges. The hook is intentionally not included here to avoid duplicating #3431.

What it does

ContextMenu and NavMenu heading menus now support first-character typeahead (type a letter to jump to the matching item), via the shared `useTypeahead` hook — matching DropdownMenu. MoreMenu inherits it through DropdownMenu.

Ref #3343.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 2, 2026
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Error Error Jul 2, 2026 7:27pm

Request Review

@cixzhang

cixzhang commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Closing as redundant: the ContextMenu + NavHeadingMenu typeahead wiring (menus-11) is already in main via #3431 (commit c891bf8), which carried the stacked #3432 content when it merged. Rebasing this branch onto main yields zero remaining commits. No action needed.

@cixzhang cixzhang closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant