cargo: Autocargo for app and friends (#1343)#1343
Open
JakobDegen wants to merge 3 commits into
Open
Conversation
Contributor
|
@JakobDegen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105682849. |
Summary: This one is correctly suppressed from unknown cfg errors Differential Revision: D108489679
bbdd856 to
9e6065a
Compare
JakobDegen
added a commit
to JakobDegen/buck2
that referenced
this pull request
Jun 13, 2026
Summary: Pull Request resolved: facebook#1343 Get us onto autocargo Specifically, this diff enables autocargo for all the crates in `fbcode/buck2` that are not published to crates.io. This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates. There's a bunch of steps that this does not take yet: - Checking in a cargo.lock - Getting lint configs to agree - Extending this to the other crates I'll try and do all of those, but one step at a time Differential Revision: D105682849
Summary: We stopped doing full asan builds Differential Revision: D108490521
JakobDegen
added a commit
to JakobDegen/buck2
that referenced
this pull request
Jun 13, 2026
Summary: Pull Request resolved: facebook#1343 Get us onto autocargo Specifically, this diff enables autocargo for all the crates in `fbcode/buck2` that are not published to crates.io. This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates. There's a bunch of steps that this does not take yet: - Checking in a cargo.lock - Getting lint configs to agree - Extending this to the other crates I'll try and do all of those, but one step at a time Differential Revision: D105682849
63225f1 to
cfef497
Compare
JakobDegen
added a commit
to JakobDegen/buck2
that referenced
this pull request
Jun 13, 2026
Summary: Pull Request resolved: facebook#1343 Get us onto autocargo Specifically, this diff enables autocargo for all the crates in `fbcode/buck2` that are not published to crates.io. This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates. There's a bunch of steps that this does not take yet: - Checking in a cargo.lock - Getting lint configs to agree - Extending this to the other crates I'll try and do all of those, but one step at a time Differential Revision: D105682849
JakobDegen
added a commit
to JakobDegen/buck2
that referenced
this pull request
Jun 13, 2026
Summary: Pull Request resolved: facebook#1343 Get us onto autocargo Specifically, this diff enables autocargo for all the crates in `fbcode/buck2` that are not published to crates.io. This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates. There's a bunch of steps that this does not take yet: - Checking in a cargo.lock - Getting lint configs to agree - Extending this to the other crates I'll try and do all of those, but one step at a time Differential Revision: D105682849
cfef497 to
9af7350
Compare
Summary: Pull Request resolved: facebook#1343 Get us onto autocargo Specifically, this diff enables autocargo for all the crates in `fbcode/buck2` that are not published to crates.io. This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates. There's a bunch of steps that this does not take yet: - Checking in a cargo.lock - Getting lint configs to agree - Extending this to the other crates I'll try and do all of those, but one step at a time Differential Revision: D105682849
9af7350 to
9ed3509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Get us onto autocargo
Specifically, this diff enables autocargo for all the crates in
fbcode/buck2that are not published to crates.io.This is (relatively speaking anyway) pretty straightforward. We set up the project configs, exclude all of the things that want to be excluded, flip some appropriate defaults, and we're off. There's a dummy buck2_published project which is there to let autocargo find the excluded crates.
There's a bunch of steps that this does not take yet:
I'll try and do all of those, but one step at a time
Differential Revision: D105682849