chore: migration from Jest to Vitest#12010
Open
slorber wants to merge 28 commits into
Open
Conversation
slorber
added
the
pr: maintenance
slorber
added
the
Argos
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
commented
May 11, 2026
Comment on lines
-157
to
+161
| await expect(testFile('invalid.yml')).rejects | ||
| .toThrowErrorMatchingInlineSnapshot(` | ||
| "The file at "packages/docusaurus-utils/src/__tests__/__fixtures__/dataFiles/dataFiles/invalid.yml" looks invalid (not Yaml nor JSON). | ||
| Cause: end of the stream or a document separator is expected (1:1) | ||
|
|
||
| 1 | }{{{{12434665¨£%£%%£%£}}}} | ||
| -----^" | ||
| `); | ||
| await expect( | ||
| testFile('invalid.yml'), | ||
| ).rejects.toThrowErrorMatchingInlineSnapshot( | ||
| `[Error: The file at "packages/docusaurus-utils/src/__tests__/__fixtures__/dataFiles/dataFiles/invalid.yml" looks invalid (not Yaml nor JSON).]`, | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Error Cause not snapshotted?
| ).rejects.toThrowErrorMatchingInlineSnapshot(` | ||
| "Docusaurus couldn't infer a default locale config for x1. | ||
| Make sure it is a valid BCP 47 locale name (e.g. en, fr, fr-FR, etc.) and/or provide a valid BCP 47 \`siteConfig.i18n.localeConfig['x1'].htmlLang\` attribute. | ||
| Cause: Incorrect locale information provided" |
| error[key] = normalizePaths(val[key]) as never; | ||
| }); | ||
| return serialize(error); | ||
| return printer(error, ...rest.slice(0, -1)); |
Collaborator
Author
There was a problem hiding this comment.
??? check this, maybe related to error cause loss?
slorber
commented
May 12, 2026
| ['./plugin4.js', {}], | ||
| './pluginEsm', | ||
| './pluginTypeScript', | ||
| './pluginTypeScript.ts' |
Collaborator
Author
There was a problem hiding this comment.
Not sure why this is now needed but it seems Vitest require the extension now while Jest didn't.
Probably not a big deal, only affects tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The whole frontend community has moved to Vitest for various reasons (ESM support, actively maintained and backed by a funded company) so let's adopt it too.
For now, this PR is mostly an AI-driven draft, I'll fix issues before merging.
I may try to minimize the diff in this PR and refactor things later to adopt good practices in follow-up PRs.
Test Plan
CI
Test links
https://deploy-preview-12010--docusaurus-2.netlify.app/