Make curl debug output more user friendly#557
Open
danihodovic wants to merge 1 commit intofacebook:mainfrom
Open
Make curl debug output more user friendly#557danihodovic wants to merge 1 commit intofacebook:mainfrom
danihodovic wants to merge 1 commit intofacebook:mainfrom
Conversation
The curl output helps when debugging requests made to the FB API. However it's not as user friendly as it should be because it retrieves gzipped content which can't immediately be displayed when running the curl command in the terminal. See the below post by the curl maintainer on why binary output is no longer displayed in stdout by default. https://daniel.haxx.se/blog/2017/06/17/curl-doesnt-spew-binary-anymore/ Instead of displaying binary output I force the API to return uncompressed JSON which can immediately be displayed when running the command. See the below two examples. Without this patch: ``` $ curl -X GET -H 'Accept: application/json' -H 'Accept-Encoding: gzip, deflate' -H 'Connection: keep-alive' -H 'User-Agent: fbbizsdk-python-v5.0.1' 'https://graph.facebook.com/v5.0/me/adaccounts?access_token=xxxxxx&summary=true' Warning: Binary output can mess up your terminal. Use "--output -" to tell Warning: curl to output it to your terminal anyway, or consider "--output Warning: <FILE>" to save to a file. ``` With this patch: ``` $ curl -X GET -H 'Accept: application/json' -H 'Connection: keep-alive' -H 'User-Agent: fbbizsdk-python-v5.0.1' 'https://graph.facebook.com/v5.0/me/adaccounts?access_token=xxxxxx&summary=true' {"data":[{"account_id":"abc","id":"act_abc"},"summary":{"total_count":1}} ```
|
Hi danihodovic! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl output helps when debugging requests made to the FB API.
However it's not as user friendly as it should be because it retrieves
gzipped content which can't immediately be displayed when running the
curl command in the terminal. See the below post by the curl maintainer
on why binary output is no longer displayed in stdout by default.
https://daniel.haxx.se/blog/2017/06/17/curl-doesnt-spew-binary-anymore/
Instead of displaying binary output I force the API to return
uncompressed JSON which can immediately be displayed when running the
command. See the below two examples.
Without this patch:
With this patch: