Normalize country (ISO 3166-1) and currency (ISO 4217) properly#714
Normalize country (ISO 3166-1) and currency (ISO 4217) properly#714dnikolayev wants to merge 1 commit intofacebook:mainfrom
Conversation
…rcase According to ISO 4217, the currency must have 3 UPPERCASE letters. ISO 3166-1 requires currency to have 2 UPPERCASE letters. While the FB Python SDK normalizes currency and country to lowercase, it makes a difference with the JS SDK, which reports in uppercase.
|
Hi @dnikolayev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
dnikolayev
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
dnikolayev
changed the title
1 participant
According to ISO 4217, the currency must have 3 UPPERCASE letters. ISO 3166-1 requires currency to have 2 UPPERCASE letters.
While the FB Python SDK normalizes currency and country to lowercase, it makes a difference with the JS SDK, which reports in uppercase.