Add ESLint v10 support to hermes-eslint#1926
Open
JasonWeinzierl wants to merge 10 commits intofacebook:static_hfrom
Open
Add ESLint v10 support to hermes-eslint#1926JasonWeinzierl wants to merge 10 commits intofacebook:static_hfrom
JasonWeinzierl wants to merge 10 commits intofacebook:static_hfrom
Conversation
This was referenced Mar 4, 2026
Member
|
Hi @JasonWeinzierl, thanks for your work! We will take a look at this, though we will need to confirm that nothing breaks internally. |
Based heavily on the [typescript-eslint PR](typescript-eslint/typescript-eslint#11914).
eslint isn't actually imported by this package, so it can be optional. Also, the supported version floor is likely much lower because the custom parser interface expected by eslint hasn't changed much since v7, maybe even v6. So drop it to v7 just to be safe.
ade11c2 to
c403ee6
Compare
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support to
hermes-eslintfor ESLint v10.ScopeManager.addGlobals().eslinttohermes-eslint's peer dependencies as optional, for documenting supported versions.esrecursetodevDependenciessince it's not required by the published code.context.getSourceCode()). For example, feat!: ESLint v10 and flat config support flow-typed/eslint-plugin-ft-flow#71 recursively needshermes-eslintto be upgraded first.@eslint/jsas a defensive measure: eslint v10 will require this to be installed.hermes-eslintwith flat config example.Note: it would be nice to see #1651 merged, since these packages published on npm do not display links to this repository, so it took me a minute to find this.
Test Plan
Ran the following commands:
Build, test, and lint passes.
Demonstration of peer dependency compatibility: https://github.com/JasonWeinzierl/hermes-eslint-compatibility-test