fix: include macOS slice in universal Hermes xcframework#1971
Open
Saadnajmi wants to merge 1 commit intofacebook:250829098.0.0-stablefrom
Open
fix: include macOS slice in universal Hermes xcframework#1971Saadnajmi wants to merge 1 commit intofacebook:250829098.0.0-stablefrom
Saadnajmi wants to merge 1 commit intofacebook:250829098.0.0-stablefrom
Conversation
meta-cla
bot
added
the
CLA Signed
cipolleschi
approved these changes
Apr 13, 2026
cipolleschi
requested changes
Apr 13, 2026
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
this change the build-ios-framework script, but shouldn't we also update the CI?
Otherwise CI will still call the other script as we build the slices in their own action.
…_architecture - Add macosx to get_architecture, get_deployment_target, create_framework, and build_universal_framework so the unified script handles all platforms - Simplify get_architecture from 5 branches to 2 - CI continues using build-mac-framework-rn.sh for the standalone macOS framework (needed by the podspec), while the assembly step now includes macosx in the universal xcframework via build_universal_framework Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Saadnajmi
force-pushed
the
saad/add-macos-to-xcframework-stable
branch
from
a8098ad to
36906cc
Compare
Author
Similar to the comment for the main branch PR, I think before my change we always had a macos slice and job in CI, and after this change we make sure that that slice is also in the universal xcframework by adding macos to build_universal_framework() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror of #1958 (targeting
static_h), adapted for the250829098.0.0-stablerelease branch.Unlike the
static_hPR which consolidates all Apple build scripts and removesbuild-mac-framework.sh, this PR takes a minimal approach: it addsbuild_apple_framework "macosx"and includes"macosx"in thecreate_universal_frameworkcall so the macOS slice is part of the universal xcframework.build-mac-framework.shis left in place for backward compatibility on this release branch.Motivation
The context of this change is microsoft/react-native-macos#2815, where we are adding SPM / prebuild support to React Native macOS.
Including the macOS slice in the universal xcframework allows react-native-macos to use the same prebuilt Hermes artifacts as react-native for iOS, visionOS, and tvOS — without platform-specific patching.
Test plan
CI should pass. The
build_apple_framework "macosx"call is already exercised bybuild-mac-framework.sh— this PR just routes it through the same path as every other platform.