fix: preserve block equations ($$) in MarkdownShortcutPlugin#8194
Open
Anas0709 wants to merge 1 commit intofacebook:mainfrom
Open
fix: preserve block equations ($$) in MarkdownShortcutPlugin#8194Anas0709 wants to merge 1 commit intofacebook:mainfrom
Anas0709 wants to merge 1 commit intofacebook:mainfrom
Conversation
Block math equations created via the toolbar were incorrectly converted to inline equations ($...$) when toggling markdown mode. This adds a BLOCK_EQUATION transformer that handles $$...$$ syntax and updates EQUATION to only export inline nodes. BLOCK_EQUATION is placed before EQUATION in PLAYGROUND_TRANSFORMERS so the $$ pattern is matched before the $ pattern. Fixes facebook#6936
Anas0709
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
Collaborator
|
I’ll review after new tests are added that demonstrates that this solves the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6936
Block math equations (
$$...$$) created via the toolbar were incorrectly converted to inline equations ($...$) when toggling markdown mode via theMarkdownShortcutPlugin.Root cause: The
EQUATIONtransformer'sexportfunction always returned$${equation}$(inline syntax) regardless of whether the node was a block or inline equation. There was also no transformer to import/match$$...$$patterns.Changes
BLOCK_EQUATIONtransformer that handles$$...$$syntax (export and import)EQUATIONtransformer to only export when the node is inline (node.__inline === true)BLOCK_EQUATIONbeforeEQUATIONinPLAYGROUND_TRANSFORMERSso the$$pattern is matched before the single$patternBefore / After
Before: inserting a block equation and clicking the Markdown button converted
$$x^2 + y^2 = z^2$$→$x^2 + y^2 = z^2$(inline)After: block equations are preserved as
$$x^2 + y^2 = z^2$$when toggling markdown mode