[lexical] Fix: Delete emptyable inline ElementNode in selection#8204
Open
levensta wants to merge 3 commits intofacebook:mainfrom
Open
[lexical] Fix: Delete emptyable inline ElementNode in selection#8204levensta wants to merge 3 commits intofacebook:mainfrom
levensta wants to merge 3 commits intofacebook:mainfrom
Conversation
levensta
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
meta-cla
bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
levensta
changed the title
Collaborator
|
I think it would be valuable here to add an actual use case to the playground so that it can be confirmed that this type of inline canBeEmpty ElementNode behaves well in real situations, since this also creates interactions with selections and other kinds of nodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users can create custom nodes that combine two methods:
canBeEmptyandisInline, which returnstrue. The current fix ensures that it will be deleted via theRangeSelection.deleteCharactermethodCloses #8205
Test plan
Before
There is no example of a node in the lexical-playground that simultaneously returns
truefor both methods:canBeEmptyandisInlineAfter
Added unit test with a synthetic example