[lexical-playground] Fix : On pressing clear formatting clears text alignment even when no formatting is applied to text#8237
Open
Jynx2004 wants to merge 9 commits intofacebook:mainfrom
Open
Conversation
Jynx2004
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
etrepum
reviewed
Mar 18, 2026
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
This PR needs tests to demonstrate that it solves the issue
Contributor
Author
I have added the unit test to check this functionality |
etrepum
reviewed
Mar 19, 2026
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
I don't think this is quite a complete solution, it's a bit greedy in that it will always clear formatting from the parent even if you've only selected some of the text. I think the block formatting should only be cleared if the block is selected, or all of its contents are selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated clear-formatting to detect the “no formatting” case by checking selection.extract() instead of comparing anchor/focus. This ensures alignment is cleared even when the selection is collapsed and no text formatting is present.
Closes #7383
lexical-format.mp4
Test plan
All the existing unit tests passed . No new tests created.