acctonbmc: Fix oob-mdio-util.sh write operation#268
Open
louis-nexthop wants to merge 1 commit into
Open
Conversation
Signed-off-by: Louis Maliyam <louis@nexthop.ai>
|
This pull request has been imported. If you are a Meta employee, you can view this in D107914551. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in the write operation of oob-mdio-util.sh.
datais the forth argument, not the third.ctrl_cmdmust be in hex representation because mdio-util expects it here. So, I usedprintf "0x%08X", similar to how it's done for the read operation.Motivation
oob-mdio-util.shhas a bug when doing a register write to the OOB management switch.Test Plan
Before:
Note: usage is
oob-mdio-util.sh {read|write} <port> <offset> [<value>]After: