acctonbmc: Fix CIT failures (test_bmc_mac, test_eeprom, test_wedge_power)

[louis-nexthop]

Description

1. Include more mac patterns: Add 2C:03:69 for Accton and E8:E4:9D for Nexthop.
2. Include more product names: WEDGE800BACT, WEDGE800CACT, WEDGE800BNHP, WEDGE800CNHP.
3. Change expected fabric on location for Chassis: It should be MCB (Main Control Board) instead of FCB (Fan Control Board)
4. Add a polling before starting the test for wedge_power.sh reset. This gives enough time for RST_PLTRST_L to be asserted first. RST_PLTRST_L was pulled low by the previous test (test_wedge_power_on_force), so we should avoid running the wedge power commands back-to-back. For context, see here.

Motivation

To fix test failures like below:

test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui) ... FAIL

======================================================================
FAIL: test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/common/base_bmc_mac_test.py", line 115, in test_bmc_mac_oui
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        found,
        ^^^^^^
        " the mac address not contain in pattern list \n"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        " {} not match in {}".format(mac, " ".join(self.mac_pattern)),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: None is not true :  the mac address not contain in pattern list
 2c:03:69:0f:1b:29
 not match in (ac\:81\:b5\:..\:..\:..)

----------------------------------------------------------------------

======================================================================
FAIL: test_location_on_fabric (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_location_on_fabric)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/common/base_eeprom_test.py", line 159, in test_location_on_fabric
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        found,
        ^^^^^^
        "Location on Fabric {} not in set {}".format(name, self.location_on_fabric),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: False is not true : Location on Fabric MCB not in set ['FCB']

======================================================================
FAIL: test_product_name (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_name)
Tests if the platform defined product name is present
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/common/base_eeprom_test.py", line 107, in test_product_name
    self.assertTrue(
    ~~~~~~~~~~~~~~~^
        found, "Product name {} not in set {}".format(name, self.product_name)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: False is not true : Product name wedge800bact not in set ['MINIPACK3N', 'MINIPACK3BA']

----------------------------------------------------------------------

======================================================================
ERROR: test_wedge_power_reset (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_reset)
Tests wedge power reset
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/run/tests2/tests/acctonbmc/test_wedge_power.py", line 185, in test_wedge_power_reset
    self.run_power_cmd_test("reset"), 0, "Power reset test failed"
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/run/tests2/tests/acctonbmc/test_wedge_power.py", line 124, in run_power_cmd_test
    return_code, _ = self.run_power_cmd(cmd)
                     ~~~~~~~~~~~~~~~~~~^^^^^
  File "/run/tests2/tests/acctonbmc/test_wedge_power.py", line 83, in run_power_cmd
    raise Exception(stderr.decode())
Exception:  Still in the process of x86 power sequencing


----------------------------------------------------------------------

Test Plan

All tests pass consistently:

root@bmc:/run/tests2# python cit_runner.py --platform acctonbmc --run-test tests.acctonbmc.test_bmc_mac
test_bmc_mac (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac) ... ok
test_bmc_mac_oui (tests.acctonbmc.test_bmc_mac.BMCMacTest.test_bmc_mac_oui) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.890s

OK
root@bmc:/run/tests2# python cit_runner.py --platform acctonbmc --run-test tests.acctonbmc.test_eeprom
test_asset_tag (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_asset_tag) ... ok
test_bmc_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_bmc_mac) ... ok
test_extended_mac_base (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_extended_mac_base) ... ok
test_local_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_local_mac) ... ok
test_location_on_fabric (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_location_on_fabric) ... ok
test_odm_pcb (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_odm_pcb) ... ok
test_product_name (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_name)
Tests if the platform defined product name is present ... ok
test_product_part_number (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_part_number) ... ok
test_product_serial_number (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_product_serial_number) ... ok
test_switch_asic_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_switch_asic_mac) ... ok
test_system_manufacturer (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_system_manufacturer) ... ok
test_version (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_version) ... ok
test_x86_mac (tests.acctonbmc.test_eeprom.CHASSISEepromTest.test_x86_mac) ... ok
test_asset_tag (tests.acctonbmc.test_eeprom.SCMEepromTest.test_asset_tag) ... ok
test_bmc_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_bmc_mac) ... ok
test_extended_mac_base (tests.acctonbmc.test_eeprom.SCMEepromTest.test_extended_mac_base) ... ok
test_local_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_local_mac) ... ok
test_location_on_fabric (tests.acctonbmc.test_eeprom.SCMEepromTest.test_location_on_fabric) ... ok
test_odm_pcb (tests.acctonbmc.test_eeprom.SCMEepromTest.test_odm_pcb) ... ok
test_product_name (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_name)
Tests if the platform defined product name is present ... ok
test_product_part_number (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_part_number) ... ok
test_product_serial_number (tests.acctonbmc.test_eeprom.SCMEepromTest.test_product_serial_number) ... ok
test_switch_asic_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_switch_asic_mac) ... ok
test_system_manufacturer (tests.acctonbmc.test_eeprom.SCMEepromTest.test_system_manufacturer) ... ok
test_version (tests.acctonbmc.test_eeprom.SCMEepromTest.test_version) ... ok
test_x86_mac (tests.acctonbmc.test_eeprom.SCMEepromTest.test_x86_mac) ... ok

----------------------------------------------------------------------
Ran 26 tests in 13.782s

OK
root@bmc:/run/tests2# python cit_runner.py --platform acctonbmc --run-test tests.acctonbmc.test_wedge_power
test_wedge_power_off (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_off)
Tests wedge power off ... ok
test_wedge_power_on (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_on)
Tests wedge power on ... ok
test_wedge_power_on_force (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_on_force)
Tests wedge power on with force ... ok
test_wedge_power_reset (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_reset)
Tests wedge power reset ... ok
test_wedge_power_status (tests.acctonbmc.test_wedge_power.WedgePowerTest.test_wedge_power_status)
Tests wedge power status ... ok

----------------------------------------------------------------------
Ran 5 tests in 19.095s

OK

[meta-codesync]

This pull request has been imported. If you are a Meta employee, you can view this in D108253300. (Because this pull request was imported automatically, there will not be any future comments.)