This repository was archived by the owner on Sep 1, 2024. It is now read-only.
Draft
Conversation
**what is the change?:** Inlines a version of 'warning' that uses `console.warn` instead of `console.error`, and then uses that for the deprecation warning. **NOTE: I'm not sure that this will only warn in development, which is a problem. We don't seem to have a '__DEV__' env. variable set up here, so I'm not sure how to limit the warnings to development?** **why make this change?:** This is a particularly noisy warning that was firing in 3rd party libraries, which then causes it to show up in product code. Users then can't silence it easily without updating their library. This makes it slightly less painful, hopefully, but still painful enough to get folks to update their code. **test plan:** `yarn test` - updated some tests to check for this. **issue:** facebook/react#9398
49 tasks
Contributor
|
We have a |
gaearon
suggested changes
May 24, 2017
Contributor
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
We don't transpile ES6 here (the build process is not fully set up) so we should limit ourselves to using ES5.
This was referenced Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
Inlines a version of 'warning' that uses
console.warninstead ofconsole.error, and then uses that for the deprecation warning.NOTE: I'm not sure that this will only warn in development, which is a problem. We don't seem to have a 'DEV' env. variable set up here, so I'm not sure how to limit the warnings to development?
why make this change?:
This is a particularly noisy warning that was firing in 3rd party libraries, which then causes it to show up in product code. Users then can't silence it easily without updating their library. This makes it slightly less painful, hopefully, but still painful enough to get folks to update their code.
test plan:
yarn test- updated some tests to check for this.issue:
facebook/react#9398