Send custom CDP Event to Frontend to prepare for displaying a trace#53079
Closed
hoxyq wants to merge 2 commits into
Closed
Send custom CDP Event to Frontend to prepare for displaying a trace#53079hoxyq wants to merge 2 commits into
hoxyq wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79672598 |
hoxyq
force-pushed
the
export-D79672598
branch
from
8742ff3 to
765839c
Compare
hoxyq
force-pushed
the
export-D79672598
branch
from
765839c to
c320514
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79672598 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79672598 |
hoxyq
force-pushed
the
export-D79672598
branch
from
c320514 to
91a1f39
Compare
Summary: # Changelog: [Internal] When CDP session is created via `HostTarget::connect`, it will ask `HostTargetDelegate` is there is a previously recorded trace that Host wants to display in the Frontend. `TracingAgent` will serialize and send the recording at the initialization time in constructor. Differential Revision: D79672597
hoxyq
force-pushed
the
export-D79672598
branch
from
91a1f39 to
117c623
Compare
…acebook#53079) Summary: Pull Request resolved: facebook#53079 # Changelog: [Internal] We need this to notify Frontend, so it updates the local state before receiving `Tracing.dataCollected` events. Corresponding change in CDT fork - react/react-native-devtools-frontend#199. Reviewed By: sbuggay Differential Revision: D79672598
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79672598 |
hoxyq
force-pushed
the
export-D79672598
branch
from
117c623 to
335393f
Compare
Contributor
|
This pull request has been merged in 80f340e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
We need this to notify Frontend, so it updates the local state before receiving
Tracing.dataCollectedevents.Corresponding change in CDT fork - react/react-native-devtools-frontend#199.
Differential Revision: D79672598