Add types for platform in React native web#53216
Closed
riteshshukla04 wants to merge 2 commits intofacebook:mainfrom
Closed
Add types for platform in React native web#53216riteshshukla04 wants to merge 2 commits intofacebook:mainfrom
riteshshukla04 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
necolas
approved these changes
Aug 13, 2025
Contributor
Contributor
Collaborator
|
This pull request was successfully merged by @riteshshukla04 in f6ba2db When will my fix make it into a release? | How to file a pick request? |
| @@ -162,7 +162,7 @@ type MacOSPlatform = { | |||
| type WebPlatform = { | |||
| OS: 'web', | |||
| // $FlowFixMe[unsafe-getters-setters] | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes #52356.
As per discussion here #52360 . We have changed the implementation in React native web in this PR necolas/react-native-web#2791.
As discussed with @cortinico , Now web returns a hardcoded string "0.0.0" for
platform.version.We can safely change this to string now.
Changelog:
[GENERAL][CHANGED] Update types for Platform.version
Test Plan:
N/A