Fix React Native multiline TextInput container overflow#56836
Open
cipolleschi wants to merge 1 commit into
Open
Fix React Native multiline TextInput container overflow#56836cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
Summary: The text input field in the Marketplace Review Response Composer (and all React Native multiline TextInput instances) incorrectly expands beyond its container bounds. The _UITextLayoutFragmentView has a width that exceeds the RCTTextInputComponentView container width by 47 points. Root cause: RCTUITextView.layoutSubviews does not update self.textContainer.size when parent view bounds change. When RCTTextInputComponentView.updateLayoutMetrics sets a new frame and textContainerInset, the NSTextContainer.size inside the UITextView retains its old (wider) value. Fix: Add self.textContainer.size = CGSizeMake(textFrame.size.width, CGFLOAT_MAX) in layoutSubviews after computing textFrame, so the text container width stays in sync with container bounds. ## Changelog [iOS][Fixed] - Update text view bounding to avoid overflowing Differential Revision: D104896433
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104896433. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The text input field in the Marketplace Review Response Composer (and all React Native multiline TextInput instances) incorrectly expands beyond its container bounds. The _UITextLayoutFragmentView has a width that exceeds the RCTTextInputComponentView container width by 47 points.
Root cause: RCTUITextView.layoutSubviews does not update self.textContainer.size when parent view bounds change. When RCTTextInputComponentView.updateLayoutMetrics sets a new frame and textContainerInset, the NSTextContainer.size inside the UITextView retains its old (wider) value.
Fix: Add self.textContainer.size = CGSizeMake(textFrame.size.width, CGFLOAT_MAX) in layoutSubviews after computing textFrame, so the text container width stays in sync with container bounds.
Changelog
[iOS][Fixed] - Update text view bounding to avoid overflowing
Differential Revision: D104896433