Inline true in ReactActivityDelegate.isFabricEnabled() (#56857)#56857
Open
mdvacca wants to merge 4 commits into
Open
Inline true in ReactActivityDelegate.isFabricEnabled() (#56857)#56857mdvacca wants to merge 4 commits into
mdvacca wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105230961. |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 15, 2026
Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default body of `ReactActivityDelegate.isFabricEnabled()` reads the flag — change it to `return true` directly. The method itself is preserved because it is a polymorphic `protected` hook that subclasses (e.g., `DefaultReactActivityDelegate`) override to provide per-activity behavior. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230961
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 15, 2026
Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default body of `ReactActivityDelegate.isFabricEnabled()` reads the flag — change it to `return true` directly. The method itself is preserved because it is a polymorphic `protected` hook that subclasses (e.g., `DefaultReactActivityDelegate`) override to provide per-activity behavior. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230961
…int (facebook#56854) Summary: The `enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. In `loadWithFeatureFlags`, replace both `featureFlags.enableFabricRenderer()` reads with the literal `true` for `privateFabricEnabled` and `privateConcurrentReactEnabled`. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105229919
…k#56855) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. In `createRootView`, inline `setIsFabric(true)` and remove the now-unused import. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230246
…56856) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The DEBUG-only `assertCondition(enableFabricRenderer(), ...)` check in `getOrCreateStartTask` becomes tautological — delete it. The other DEBUG assertions in the same block (`enableBridgelessArchitecture`, `useTurboModules`) are unaffected. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230489
Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default body of `ReactActivityDelegate.isFabricEnabled()` reads the flag — change it to `return true` directly. The method itself is preserved because it is a polymorphic `protected` hook that subclasses (e.g., `DefaultReactActivityDelegate`) override to provide per-activity behavior. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230961
meta-codesync
Bot
changed the title
mdvacca
force-pushed
the
export-D105230961
branch
from
4edafcd to
a474cf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()flag is being deleted; it always returns true on the canary release stage. The default body ofReactActivityDelegate.isFabricEnabled()reads the flag — change it toreturn truedirectly.The method itself is preserved because it is a polymorphic
protectedhook that subclasses (e.g.,DefaultReactActivityDelegate) override to provide per-activity behavior.Behavior is unchanged.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D105230961