Delete enableFabricRenderer() from ReactNativeNewArchitectureFeatureFlags (#56860)#56860
Open
mdvacca wants to merge 6 commits into
Open
Delete enableFabricRenderer() from ReactNativeNewArchitectureFeatureFlags (#56860)#56860mdvacca wants to merge 6 commits into
mdvacca wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105231777. |
…int (facebook#56854) Summary: The `enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. In `loadWithFeatureFlags`, replace both `featureFlags.enableFabricRenderer()` reads with the literal `true` for `privateFabricEnabled` and `privateConcurrentReactEnabled`. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105229919
…k#56855) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. In `createRootView`, inline `setIsFabric(true)` and remove the now-unused import. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230246
…56856) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The DEBUG-only `assertCondition(enableFabricRenderer(), ...)` check in `getOrCreateStartTask` becomes tautological — delete it. The other DEBUG assertions in the same block (`enableBridgelessArchitecture`, `useTurboModules`) are unaffected. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230489
Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default body of `ReactActivityDelegate.isFabricEnabled()` reads the flag — change it to `return true` directly. The method itself is preserved because it is a polymorphic `protected` hook that subclasses (e.g., `DefaultReactActivityDelegate`) override to provide per-activity behavior. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105230961
) Summary: The `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` flag is being deleted; it always returns true on the canary release stage. The default initializer of `ReactDelegate.isFabricEnabled` reads the flag — change it to `true` directly. The field itself is preserved because it can be set by the deprecated `(activity, reactNativeHost, appKey, launchOptions, fabricEnabled)` constructor that lets callers override the default. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231216
…lags (facebook#56860) Summary: The `enableFabricRenderer()` flag is being removed entirely; it was always set to true in the canary release stage. All callers of `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` were inlined in earlier diffs. This diff: - Removes the wrapper method `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()`. - Removes the `override fun enableFabricRenderer(): Boolean = true` from `ReactNativeNewArchitectureFeatureFlagsDefaults`. Both classes are non-`generated`, so they are edited directly. The next diff will remove the underlying `ReactNativeFeatureFlags.enableFabricRenderer()` API by regenerating the codegen output. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231777
meta-codesync
Bot
changed the title
mdvacca
force-pushed
the
export-D105231777
branch
from
7d4bf0d to
7f6cdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableFabricRenderer()flag is being removed entirely; it was always set to true in the canary release stage. All callers ofReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()were inlined in earlier diffs.This diff:
ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer().override fun enableFabricRenderer(): Boolean = truefromReactNativeNewArchitectureFeatureFlagsDefaults.Both classes are non-
generated, so they are edited directly. The next diff will remove the underlyingReactNativeFeatureFlags.enableFabricRenderer()API by regenerating the codegen output.Behavior is unchanged.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D105231777