Skip to content

[eslint-plugin-react-hooks] Include cycle-entry segment in cyclic set #36324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasbuilds wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −2
Open

[eslint-plugin-react-hooks] Include cycle-entry segment in cyclic set #36324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b969a1
[eslint-plugin-react-hooks] Include cycle-entry segment in cyclic set
thomasbuilds Apr 21, 2026
55615da
Merge branch 'main' into main
thomasbuilds Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,30 @@ const allTests = {
`,
errors: [loopError('useHookInsideLoop')],
},
{
code: normalizeIndent`
// Invalid because it's dangerous and might not warn otherwise.
// This *must* be invalid.
function ComponentWithHookInLoopCondition() {
while (useHookInsideLoop()) {
foo();
}
}
`,
errors: [loopError('useHookInsideLoop')],
},
{
code: normalizeIndent`
// Invalid because it's dangerous and might not warn otherwise.
// This *must* be invalid.
function ComponentWithHookInForCondition() {
for (; useHookInsideLoop(); ) {
foo();
}
}
`,
errors: [loopError('useHookInsideLoop')],
},
{
code: normalizeIndent`
// Invalid because it's dangerous and might not warn otherwise.
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin-react-hooks/src/rules/RulesOfHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ const rule = {
if (pathList.has(segment.id)) {
const pathArray = [...pathList];
const cyclicSegments = pathArray.slice(
pathArray.indexOf(segment.id) + 1,
pathArray.indexOf(segment.id),
);
for (const cyclicSegment of cyclicSegments) {
cyclic.add(cyclicSegment);
Expand Down Expand Up @@ -422,7 +422,7 @@ const rule = {
if (pathList.has(segment.id)) {
const pathArray = Array.from(pathList);
const cyclicSegments = pathArray.slice(
pathArray.indexOf(segment.id) + 1,
pathArray.indexOf(segment.id),
);
for (const cyclicSegment of cyclicSegments) {
cyclic.add(cyclicSegment);
Expand Down