Skip to content

Add autoReset prop to opt out of automatic form reset on actions #36334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hassanzadeh-mj wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −7
Open

Add autoReset prop to opt out of automatic form reset on actions #36334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/react-dom-bindings/src/events/plugins/FormActionEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ function extractEvents(
}
const formInst = maybeTargetInst;
const form: HTMLFormElement = (nativeEventTarget: any);
let action = coerceFormActionProp(
(getFiberCurrentPropsFromNode(form): any).action,
);
const formProps = (getFiberCurrentPropsFromNode(form): any);
let action = coerceFormActionProp(formProps.action);
const autoReset: boolean = formProps.autoReset !== false;
let submitter: null | void | HTMLInputElement | HTMLButtonElement =
(nativeEvent: any).submitter;
let submitterAction;
Expand Down Expand Up @@ -124,6 +124,7 @@ function extractEvents(
// the action.
null,
formData,
autoReset,
);
} else {
// No earlier event scheduled a transition. Exit without setting a
Expand All @@ -144,7 +145,7 @@ function extractEvents(
if (__DEV__) {
Object.freeze(pendingState);
}
startHostTransition(formInst, pendingState, action, formData);
startHostTransition(formInst, pendingState, action, formData, autoReset);
} else {
// No earlier event prevented the default submission, and no action was
// provided. Exit without setting a pending form status.
Expand Down Expand Up @@ -180,5 +181,7 @@ export function dispatchReplayedFormAction(
if (__DEV__) {
Object.freeze(pendingState);
}
startHostTransition(formInst, pendingState, action, formData);
const autoReset: boolean =
(getFiberCurrentPropsFromNode(form): any).autoReset !== false;
startHostTransition(formInst, pendingState, action, formData, autoReset);
}
7 changes: 5 additions & 2 deletions packages/react-reconciler/src/ReactFiberHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3240,6 +3240,7 @@ export function startHostTransition<F>(
pendingState: TransitionStatus,
action: (F => mixed) | null,
formData: F,
autoReset: boolean = true,
): void {
if (formFiber.tag !== HostComponent) {
throw new Error(
Expand Down Expand Up @@ -3271,8 +3272,10 @@ export function startHostTransition<F>(
// set the pending form status.
noop
: () => {
// Automatically reset the form when the action completes.
requestFormReset(formFiber);
if (autoReset) {
// Automatically reset the form when the action completes.
requestFormReset(formFiber);
}
return action(formData);
},
);
Expand Down