Skip to content

Fix DevTools installHook.js source map warning in browser console (#32339) #36336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hassanzadeh-mj wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

Fix DevTools installHook.js source map warning in browser console (#32339) #36336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/react-devtools-extensions/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,28 @@ module.exports = {
}),
new Webpack.SourceMapDevToolPlugin({
filename: '[file].map',
include: ['installHook.js', 'react_devtools_backend_compact.js'],
include: ['installHook.js'],
noSources: !__DEV__,
// In production, don't append the sourceMappingURL comment. installHook.js
// runs in the page's MAIN world, so browsers resolve the source map URL
// relative to the page origin (not the extension URL), causing a failed
// network request and a console warning in every app with DevTools installed.
append: __DEV__ ? undefined : false,
// https://github.com/webpack/webpack/issues/3603#issuecomment-1743147144
moduleFilenameTemplate(info) {
const {absoluteResourcePath, namespace, resourcePath} = info;

if (isAbsolute(absoluteResourcePath)) {
return relative(__dirname + '/build', absoluteResourcePath);
}

// Mimic Webpack's default behavior:
return `webpack://${namespace}/${resourcePath}`;
},
}),
new Webpack.SourceMapDevToolPlugin({
filename: '[file].map',
include: ['react_devtools_backend_compact.js'],
noSources: !__DEV__,
// https://github.com/webpack/webpack/issues/3603#issuecomment-1743147144
moduleFilenameTemplate(info) {
Expand Down