Fix false positive for self-referential useCallback#36337
Open
KimHyeongRae0 wants to merge 1 commit intofacebook:mainfrom
Open
Fix false positive for self-referential useCallback#36337KimHyeongRae0 wants to merge 1 commit intofacebook:mainfrom
KimHyeongRae0 wants to merge 1 commit intofacebook:mainfrom
Conversation
liufang88789-ui
left a comment
There was a problem hiding this comment.
This is a tricky one to get right. The distinction between a stable self-reference (callback capturing itself through memoization) and a genuine TDZ violation is subtle, and the old code couldn't tell them apart.
The approach works well - by tracking which captures are introduced by the memoization itself versus which are genuine out-of-order reads, you avoid the false positive while keeping the real TDZ check intact.
The two regression tests are the right cases: removing itself is exactly the stable self-reference pattern that should be allowed, and reading before is declared is a legitimate error that should still be caught. Good coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35576.
The immutability rule currently reports a TDZ-style error for a stable self-reference inside useCallback, such as removing the same callback from an event listener.
This updates hoisted context tracking to only record real reads that happen before initialization. Self-references introduced by the callback being memoized are ignored, while later captures that actually read a declaration before initialization still fail.
Tests: