fix typescript type assertions with use_import_type_syntax=true#5248
fix typescript type assertions with use_import_type_syntax=true#5248PatrykWalach wants to merge 1 commit intofacebook:mainfrom
use_import_type_syntax=true#5248Conversation
|
Hi @PatrykWalach! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Overview
Fix for an issue where
useImportTypeSyntax: truegenerates runtime errors in typescript when relay resolvers are used.The changes are a bit ugly but as per comment the assertions are a short term solution
Tests
I'm guessing it's not possible to toggle feature flags per fixture. I've manually tested this against my project:
Closes #4818