Do not report misplaced-load lint in WORKSPACE files

[abhinavgautam01]

Fixes #145.

Summary

This PR fixes a false-positive lint warning in Bazel workspace files.

misplaced-load currently warns when a load(...) is not at the top of a file.
That behavior is useful for normal Starlark files, but it is noisy for WORKSPACE / WORKSPACE.bazel, where repository setup calls may legitimately appear before
load(...).

Changes

• Skip FlowIssue::MisplacedLoad for files named:
• WORKSPACE
• WORKSPACE.bazel
• Keep existing misplaced-load behavior unchanged for all other files.
• Add focused tests in starlark/src/analysis/flow.rs:
• test_lint_misplaced_load_workspace
• test_lint_misplaced_load_workspace_bazel

Validation

• cargo test -p starlark test_lint_misplaced_load --lib
• cargo clippy
• cargo build
• cargo test
• cargo bench

[meta-codesync]

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103520777. (Because this pull request was imported automatically, there will not be any future comments.)

[abhinavgautam01]

ping @ndmitchell

[JakobDegen]

Baking this into the dialect-agnostic starlark doesn't really feel right.

First of all, what does the spec have to say about the placement of load statements, I thought they had to be at the top?

In any case, the appropriate way to do this would be to plumb it through properly and have the dialect report it among other interpreter-configuration settings in the evaluator (or somewhere similar)

[JakobDegen]

Review automatically exported from Phabricator review in Meta.

[abhinavgautam01]

Baking this into the dialect-agnostic starlark doesn't really feel right.

First of all, what does the spec have to say about the placement of load statements, I thought they had to be at the top?

In any case, the appropriate way to do this would be to plumb it through properly and have the dialect report it among other interpreter-configuration settings in the evaluator (or somewhere similar)

thanks, agreed. i moved this out of the dialect-agnostic flow lint path...

the misplaced-load lint now stays enabled by default via a new dialect setting, enable_load_after_statement: false, so standard Starlark behavior is unchanged. Bazel mode now opts into that setting only when parsing WORKSPACE or WORKSPACE.bazel, which keeps the WORKSPACE-specific exception in the Bazel dialect/configuration path rather than baking filename logic into the generic analyzer...

i also added tests for both sides:

• generic flow lint respects the dialect flag
• Bazel mode enables the flag for WORKSPACE/WORKSPACE.bazel and not BUILD.bazel

[JakobDegen]

Review automatically exported from Phabricator review in Meta.