Deps/bump 2026 05#190
Conversation
…rpop 0.20) - workspace derive_more: 1.0.0 -> 2 (full features); fix two manual impl Display sites to use std::fmt::Display directly (def.rs, tests/opt/if_rand.rs). - starlark/Cargo.toml: rustyline 14 -> 18; textwrap 0.11 -> 0.16. - starlark_lsp/Cargo.toml: textwrap 0.11 -> 0.16. - starlark_syntax/Cargo.toml: lalrpop 0.19 -> 0.20 (build + util); rename ParseError::UnrecognizedEOF -> UnrecognizedEof at 2 sites (parser_lalrpop.rs and its test). - Caret-loosen ~46 patch-pinned deps across workspace + per-crate manifests (e.g. anyhow = "1.0.65" -> "1") to allow downstream consumers' lockfiles to resolve without artificially-narrow constraints. Workspace builds clean (cargo build --workspace + cargo test --no-run). Rationale: dedup transitive crate versions for downstream codex-rs build. Originally these were the older majors of widely-shared crates (convert_case 0.6 via derive_more 1, rustyline 14, textwrap 0.11) which forced a cross- version split with everyone else's modern toolchain. Bumping to current majors removes the split while staying API-compatible after the small migration above.
…orkspace inheritance
- lsp-types and lalrpop[-util] moved to workspace dep so all consumers (starlark_bin,
starlark_lsp, starlark_syntax) inherit a single source of truth (`{ workspace = true }`).
- lalrpop bumped 0.20 -> 0.23 (workspace + build dep). Migrate starlark_syntax/build.rs:
lalrpop >=0.21 forbids combining `use_cargo_dir_conventions()` with `process_file()`;
switch to plain `process()` which honours the cargo conventions internally.
- smallvec workspace declaration: enable `const_generics` + `union` features.
Required so pagable's `SmallVec<[T; N]>` impls (with const-generic N) link against
the smallvec::Array trait under modern smallvec versions.
- starlark/Cargo.toml: strsim 0.10 -> 0.11 (drops a transitive cross-version split with
clap_builder which already uses 0.11).
- lsp-types kept at 0.94 in workspace: the 0.97 jump removed `lsp_types::Url` and broke
~7 sites in starlark_lsp/server.rs, beyond this slice's scope; left as a follow-up.
|
Hi @lotuseater! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
ndmitchell
left a comment
ndmitchell
left a comment
There was a problem hiding this comment.
Most of these are downgrades, not upgrades.
| [dependencies] | ||
| proc-macro2 = "1.0" | ||
| quote = "1.0.3" | ||
| quote = "1" |
There was a problem hiding this comment.
This is a downgrade, not an upgrade
| } | ||
|
|
||
| impl<V> Display for DefGen<V> { | ||
| impl<V> std::fmt::Display for DefGen<V> { |
There was a problem hiding this comment.
I don't see why this is here at all
3 participants
Updating versions of various dependencies.
It has good impact on the build time and size of a project that uses starlark-rust.