Open
Conversation
My initial attempt at D90919043 only uncovered more failures, so try and fix the remaining ones: * Add missing entry for Ubuntu Noble to substcontrol.py. * Run `install-system-packages.sh` in a venv to workaround the unconditional `pip install pex` call from getdeps. `pex` isn't actually relevant to the watchman build so this just needs to not fail. * Reapply D93644456 so that we don't produce random shared libraries that conflict with system ones. This appears to have been unintentionally unfixed by D94714599. * Build fast_float from source on Fedora < 42. * Drop Fedora 40, add Fedora 43. * Update third-party workflow versions as we're here. Tested via: * https://github.com/mszabo-wikia/watchman/actions/runs/23025768943 * https://github.com/mszabo-wikia/watchman/actions/runs/23025768938 Fixes facebook#1339, fixes facebook#1337, fixes facebook#1335, fixes facebook#1301, fixes facebook#1299, fixes facebook#1282, fixes facebook#1256
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D96389339. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial attempt at D90919043 only uncovered more failures, so try and fix the remaining ones:
install-system-packages.shin a venv to workaround the unconditionalpip install pexcall from getdeps.pexisn't actually relevant to the watchman build so this just needs to not fail.Tested via:
Fixes #1339, fixes #1337, fixes #1335, fixes #1301, fixes #1299, fixes #1282, fixes #1280, fixes #1256