loop efficiency w/ cupy#155
Open
prasad-aditya wants to merge 18 commits intofacebookresearch:mainfrom
Open
Conversation
Contributor
Author
Contributor
Author
|
Can possibly use this action in workflow? @zpapakipos @jbitton |
zpapakipos
requested changes
Nov 25, 2021
zpapakipos
requested changes
Nov 29, 2021
Contributor
zpapakipos
left a comment
There was a problem hiding this comment.
Overall this looks great! Since you're adding a new optional dependency, we should document that so users know how to add gpu support when installing augly. Can you add a note about this in the audio README "Installation" section? For example you could add after what's already in that section, "If you have CUDA in your environment & want to use GPU-acceleration to speed up the audio augmentations, you can install augly using the following command: pip install augly[av,gpu]."
zpapakipos
requested changes
Dec 1, 2021
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
Co-authored-by: Zoe Papakipos <zpapakipos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related Issue
Fixes N/A
Summary
<Please summarize what you are trying to achieve, what changes you made, and how they acheive the desired result.>
Added
cupyas a dependency, rewroteloopaccordingly.Previous runtime: 0.14577968645095826s
New runtime: 0.006239746809005737s
ISSUES
Local machine does not have CUDA installed, so cannot rely on it to pass unit testing or install
cupy.Unit Tests
If your changes touch the
audiomodule, please run all of theaudiotests and paste the output here. Likewise forimage,text, &video. If your changes could affect behavior in multiple modules, please run the tests for all potentially affected modules. If you are unsure of which modules might be affected by your changes, please just run all the unit tests.Audio
python -m unittest discover -s augly/tests/audio_tests/ -p "*"Image
Text
python -m unittest discover -s augly/tests/text_tests/ -p "*"Video
python -m unittest discover -s augly/tests/video_tests/ -p "*"All
python -m unittest discover -s augly/tests/ -p "*"Other testing
If applicable, test your changes and paste the output here. For example, if your changes affect the requirements/installation, then test installing augly in a fresh conda env, then make sure you are able to import augly & run the unit test