Improve flsim/utils/example_utils.py compatibility#58
Improve flsim/utils/example_utils.py compatibility#58menglutao wants to merge 7 commits intofacebookresearch:mainfrom
Conversation
|
Hi @menglutao! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@JohnlNguyen Hi Johnl, could you please review my PR when you're available? And about the CircleCI Pipeline, how to pass this? |
|
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for the PR! Sorry I was out and didn't see this. |
|
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@JohnlNguyen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Types of changes
Motivation and Context / Related issue
This PR introduces changes in example_utils.py to handle different data types more robustly, ensuring compatibility with a wider range of datasets.
Changes:
Updated the collate_fn and fl_training_batch methods in example_utils.py to include type checks and conversions. If user is incorporating datasets beyond the initially supported ones(cifar10/cifar100 etc), these changes will solve potential compatibility issues when integrating new datasets.
How Has This Been Tested (if it applies)
Validated the updated example_utils.py with a new dataset to confirm compatibility.
Checklist
The tests are failing even from the initial repo I forked from there. I suggest the team improve on the tests.