Fix memory leak warning for unordered_multimap in IndexIVFFlatDedup Python binding (#1667)#5145
Open
anishesg wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix memory leak warning for unordered_multimap in IndexIVFFlatDedup Python binding (#1667)#5145anishesg wants to merge 1 commit intofacebookresearch:mainfrom
anishesg wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…ython binding (facebookresearch#1667) When running the Python test suite, SWIG emits a warning: Signed-off-by: anish k <ak8686@princeton.edu>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the Python test suite, SWIG emits a warning:
The root cause is that
faiss::IndexIVFFlatDedup::instancesis astd::unordered_multimap<idx_t, idx_t>member, and SWIG has no built-in destructor registration for that STL type. When SWIG wraps the field, it generates a raw pointer wrapper with no cleanup, causing the leak warning whenever anIndexIVFFlatDedupobject is garbage-collected on the Python side.The fix adds
%ignore faiss::IndexIVFFlatDedup::instancesinfaiss/python/swigfaiss.swigbefore the%include <faiss/IndexIVFFlat.h>directive. This prevents SWIG from generating the untyped wrapper for the internal dedup map (which was never exposed in the Python type stubs anyway) and eliminates the memory leak warning.Fixes #1667