Make tasks_per_node optional#2157
Conversation
|
Hi @OhadRubin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Jasha10
left a comment
Jasha10
left a comment
There was a problem hiding this comment.
Thanks @OhadRubin! Sorry this took so long to review :P
| gpus_per_node: Optional[int] = None | ||
| # number of tasks to spawn on each node | ||
| tasks_per_node: int = 1 | ||
| tasks_per_node: Optional[int] = None |
There was a problem hiding this comment.
Maybe we should leave the default value as 1 to keep backward compatibility with older versions of the submitit launcher plugin?
3 participants
This pull request fixes #1898
With the latest version of submitit, tasks_per_node became optional. see here.
(need to change requirements.txt as well)