Add args and kwargs keys and arguments in raise#2233
Conversation
Debugging issues without the given arguments and kwarguments is needlessly complex, I am adding such details to make it easier.
|
Hi @AntreasAntoniou! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
thanks for the contribution @AntreasAntoniou - it looks like you need to update the tests as well. |
Debugging issues without the given arguments and kwarguments is needlessly complex, I am adding such details to make it easier.
Motivation
I have found that debugging issues regarding arguments and kwarguments without any clues as to what those are is needlessly hard. I have decided to include those in my error reporting messages, and I think the wider community would benefit from that as well.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Standard/existing tests involving implemented Exceptions should suffice.