Skip to content

Synchronize with submitit Slurmexecutor python arg addition#2830

Open
berombau wants to merge 3 commits into
facebookresearch:mainfrom
berombau:main
Open

Synchronize with submitit Slurmexecutor python arg addition#2830
berombau wants to merge 3 commits into
facebookresearch:mainfrom
berombau:main

Conversation

@berombau

@berombau berombau commented Jan 5, 2024

Copy link
Copy Markdown

Motivation

Synchronizing with now merged submitit change (facebookincubator/submitit#1729) that allows to pass in a "python" variable to SlurmExecutor.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

This minimal added optional variable works for my setup.

Related Issues and PRs

The previous PR #2654 does the same, but the PR was closed before it could be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2024
@adamtupper

Copy link
Copy Markdown

This would be an amazing addition. I cannot use the Submitit plugin without it on our cluster.

@lauritsf lauritsf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contribution is of high value to people working on larger HPC clusters, where the preferred approach is to use singularity containers.

The naming and default match the existing init keys.

@omry

omry commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks, I will fix this.

@omry omry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks like a useful addition, but it needs a bit more before I can take it:

  • Add tests covering the new hydra.launcher.python / slurm_python behavior.
  • Add a plugin news fragment for hydra-submitit-launcher.

Please also make sure the implementation handles the Submitit version requirement cleanly, since Hydra currently allows older Submitit versions that may not support this constructor argument.

@omry omry added the awaiting_response Awaiting response label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting_response Awaiting response CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants