feat: raise UnsupportedExtensionException when loading .yml files#2890
Open
ndormann wants to merge 1 commit into
Open
feat: raise UnsupportedExtensionException when loading .yml files#2890ndormann wants to merge 1 commit into
ndormann wants to merge 1 commit into
Conversation
ndormann
force-pushed
the
feat/exception_on_invalid_file
branch
from
1af7b56 to
4e87b94
Compare
facebook-github-bot
added
the
CLA Signed
ndormann
force-pushed
the
feat/exception_on_invalid_file
branch
from
4e87b94 to
7f3bc1d
Compare
ndormann
changed the title
Jasha10
approved these changes
Apr 11, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| config_search_path=create_config_search_path(path) | ||
| ) | ||
| with raises(UnsupportedExtensionException): | ||
| cfg = config_loader.load_configuration( |
Check warning
Code scanning / CodeQL
Variable defined multiple times
| class HydraDeprecationError(HydraException): ... | ||
|
|
||
|
|
||
| class UnsupportedExtensionException(HydraException): ... |
Check notice
Code scanning / CodeQL
Statement has no effect
2 tasks
Author
|
@Jasha10 what is the status on merging this? |
omry
requested changes
Jun 8, 2026
omry
left a comment
omry
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the PR. This is a real bugfix and I would like to get it into 1.4, but I need a few changes before merging.
Please update the PR to:
- Add a news fragment, likely
news/2889.bugfix. - Assert the exception message in the test, not only the exception type.
- Either use an existing Hydra exception with the clearer message, or explain why this needs a new public exception type.
Once those are addressed, I can take another look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When trying to open a config with the unsupported extension .yml a misleading MissingConfigException is returned.
For details see #2889
The proposed change raises a UnsupportedExtensionException with a helpful error message.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The test
test_load_yml_filehas been adapted to check that the exception is raised correctly.Related Issues and PRs
#2889