Add gpsampler#2995
Conversation
|
I did not realize that I basically duplicated #2360. Can we merge one of these in? |
|
It also appears that the workflows for CI do not trigger with a PR from a forked branch. |
|
Hello @jesszzzz, can we ask you to review the PR? |
|
Let me kindly ping @jesszzzz. |
|
Sorry for the delay! I do expect some tests will break from this, #3020 enables running CI on forked PRs so please rebase when that's merged. Otherwise these changes look fine to me! |
|
Thank you for letting us know! |
b3bd748 to
e012c26
Compare
|
@jesszzzz it looks like you need to approve the 2 workflows to run since I am a first time contributor. I ran all the Pytest tests locally without issue, just need to run the workflows. |
|
Let me kindly ping as well. 🙏 @jesszzzz |
|
@jesszzzz any updates here? |
|
Any updates on getting this merged? Getting this in will be awesome |
|
Thank you for the PR and for pushing the Optuna plugin forward. I am going to close this as superseded by #3046, which is the current Optuna compatibility upgrade PR. The Optuna API compatibility work is still relevant, but I would like to handle it in that newer compatibility-focused PR/lane rather than keep multiple overlapping upgrade PRs open. The GPSampler addition is also a separate enhancement from the compatibility upgrade, especially because it brings heavier optional dependencies. That should be considered separately after the core Optuna compatibility work is settled. |
Motivation
I wanted to bring the Optuna plugin up to date with the newest version. I made the necessary changes to make the plugin compatible. I also added in the GPSampler even though it is still experimental since some people may want to use it.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
I modified the existing tests in the plugin folder. I have tested that they pass on my WSL setup.
Related Issues and PRs
Issues:
#2562
#2162
PRs:
#2360