Skip to content

Add gpsampler#2995

Closed
michaelriedl wants to merge 5 commits into
facebookresearch:mainfrom
michaelriedl:add-gpsampler
Closed

Add gpsampler#2995
michaelriedl wants to merge 5 commits into
facebookresearch:mainfrom
michaelriedl:add-gpsampler

Conversation

@michaelriedl

@michaelriedl michaelriedl commented Dec 1, 2024

Copy link
Copy Markdown

Motivation

I wanted to bring the Optuna plugin up to date with the newest version. I made the necessary changes to make the plugin compatible. I also added in the GPSampler even though it is still experimental since some people may want to use it.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

I modified the existing tests in the plugin folder. I have tested that they pass on my WSL setup.

Related Issues and PRs

Issues:
#2562
#2162

PRs:
#2360

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2024
@michaelriedl

Copy link
Copy Markdown
Author

I did not realize that I basically duplicated #2360. Can we merge one of these in?

@michaelriedl

Copy link
Copy Markdown
Author

It also appears that the workflows for CI do not trigger with a PR from a forked branch.

Comment thread plugins/hydra_optuna_sweeper/setup.py Outdated
@himkt

himkt commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

Hello @jesszzzz, can we ask you to review the PR?

@himkt

himkt commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

Let me kindly ping @jesszzzz.

@jesszzzz

jesszzzz commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

Sorry for the delay! I do expect some tests will break from this, #3020 enables running CI on forked PRs so please rebase when that's merged. Otherwise these changes look fine to me!

@himkt

himkt commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

Thank you for letting us know!
cc. @michaelriedl

@michaelriedl

michaelriedl commented Feb 5, 2025

Copy link
Copy Markdown
Author

Sorry for the delay! I do expect some tests will break from this, #3020 enables running CI on forked PRs so please rebase when that's merged. Otherwise these changes look fine to me!

@jesszzzz Rebased as requested.

@michaelriedl

Copy link
Copy Markdown
Author

@jesszzzz it looks like you need to approve the 2 workflows to run since I am a first time contributor. I ran all the Pytest tests locally without issue, just need to run the workflows.

@himkt

himkt commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Let me kindly ping as well. 🙏 @jesszzzz

@tadejsv

tadejsv commented Mar 21, 2025

Copy link
Copy Markdown

@jesszzzz any updates here?

@nefario7

Copy link
Copy Markdown

Any updates on getting this merged? Getting this in will be awesome
@jesszzzz

@omry

omry commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the PR and for pushing the Optuna plugin forward.

I am going to close this as superseded by #3046, which is the current Optuna compatibility upgrade PR. The Optuna API compatibility work is still relevant, but I would like to handle it in that newer compatibility-focused PR/lane rather than keep multiple overlapping upgrade PRs open.

The GPSampler addition is also a separate enhancement from the compatibility upgrade, especially because it brings heavier optional dependencies. That should be considered separately after the core Optuna compatibility work is settled.

@omry omry closed this Jun 8, 2026
@omry omry removed the triage label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants