make multirun behaves more like run#3107
Open
clouds56 wants to merge 6 commits into
Open
Conversation
Author
|
I have a question that, in order to detect if the key is group, we need config_loader, I'm not sure if we should use loader from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before this PR,
BasicSweeper.split_argumentswould keep only last override for the same key.in case
a=1,2,3 a=10,20,30it works well, but in casea={x:10} a={y:20}it would have different behavior betweenMULTI_RUNandRUN.This PR introduce
BasicSweeper.simplify_overridesthat would try its best to remove duplicated key override.OverrideType.CHANGE)(str, int, bool, float, list)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
fixes #3106
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)