add explicit setting to disable torch nccl timing#203
Closed
jushg wants to merge 1 commit intofacebookresearch:mainfrom
Closed
add explicit setting to disable torch nccl timing#203jushg wants to merge 1 commit intofacebookresearch:mainfrom
jushg wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: Add a param in the base parser to set `torch_nccl_enable_timing` variable to `False` by default, and only set it to true if user needed. This value is used only on flight-recorder (for debugging purpose), and significantly affect performance of benchmarking in blocking mode (~30% for small-mid message sizes) if enable Reviewed By: kingchc Differential Revision: D72240605
jushg
requested review from
briancoutinho,
kingchc,
louisfeng,
shengbao-zheng and
sunghlin
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72240605 |
Contributor
|
This pull request has been merged in b721662. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a param in the base parser to set
torch_nccl_enable_timingvariable toFalseby default, and only set it to true if user needed.This value is used only on flight-recorder (for debugging purpose), and significantly affect performance of benchmarking in blocking mode (~30% for small-mid message sizes) if enable
Reviewed By: kingchc
Differential Revision: D72240605