Change PrevLow property to nullable double#25
Open
weiwenzhou wants to merge 2 commits intofactset:mainfrom
Open
Change PrevLow property to nullable double#25weiwenzhou wants to merge 2 commits intofactset:mainfrom
weiwenzhou wants to merge 2 commits intofactset:mainfrom
Conversation
|
Hi @weiwenzhou, Thanks for proposing these changes. Our team is currently adjusting the spec to ensure prevLow is nullable. This should allow you to proceed. Will update here after the spec change is pushed to production. Let me know if you have any additional questions! Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the
Guidancemodel in the FactSet Estimates SDK. ThePrevLowproperty is now nullable, allowing it to represent cases where a previous low value is not available.PrevLowproperty fromdoubletodouble?(nullable double) in theGuidanceclass to better handle missing or unavailable data.